[libcxx-commits] [PATCH] D99095: [libcxx] [test] Add XFAIL LIBCXX-WINDOWS-FIXME in 124 tests that fail in the CI configuration
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 25 10:40:56 PDT 2021
Mordante added a comment.
In D99095#2648608 <https://reviews.llvm.org/D99095#2648608>, @mstorsjo wrote:
> In D99095#2648525 <https://reviews.llvm.org/D99095#2648525>, @Mordante wrote:
>> I'm not sure how temporary this solution is, but there's an issue with the feature-test macro script after this commit. IMO if it's very temporary we don't need to take action otherwise I think we should look at a fix.
> In very general terms, some of the added xfails won't stay for long, while others certainly will stick around for some time. (The fix then either being some change making the tests pass, or changed into `UNSUPPORTED: windows` or `XFAIL: windows` after analysis and explanation why.) It partially comes down to review throughput too ;-)
I was mainly concerned regarding the XFAILS for the feature-test macros. Obviously it would be great of all can be fixed.
I like the work you do to improve the Windows support!
Comment at: libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.pass.cpp:16
+// XFAIL: LIBCXX-WINDOWS-FIXME
> Mordante wrote:
> > This file and the other `*.version.pass.cpp` are automatically generated by `utils/generate_feature_test_macro_components.py`. If a developer runs this script these changes will accidentally be reverted. I'm not sure what would be the best fix for now.
> Those particular xfails can be removed with D99213
Since D99213 has landed, could you commit a fix for them?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits