[libcxx-commits] [PATCH] D99104: [libcxx] rearranges all concept tests

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 25 10:48:30 PDT 2021


zoecarver added a comment.

Thanks for separating the patches. Now it's super easy to verify correctness. This LGTM (sans the comment about functions.h).



================
Comment at: libcxx/test/std/concepts/concepts.callable/concept.invocable/invocable.pass.cpp:21
 
-#include "functions.h"
+#include "../functions.h"
 
----------------
Where else is `functions.h` used? Maybe we should move it into this directory. Or maybe in the `support` folder?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99104/new/

https://reviews.llvm.org/D99104



More information about the libcxx-commits mailing list