[libcxx-commits] [PATCH] D99104: [libcxx] rearranges all concept tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 25 07:02:32 PDT 2021


ldionne added a comment.

The original motivation for `.compile.pass.cpp` is to avoid running the tests when it's not needed. It doesn't actually matter in any current configuration we test in the CI, but it does matter a bit more when the executor is slow, for example when running the tests through SSH or when running on an emulator for some embedded chip. I still think it would be reasonable to get rid of them for the reasons explained by others, but I wanted to clarify what the actual purpose of that test format is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99104/new/

https://reviews.llvm.org/D99104



More information about the libcxx-commits mailing list