[libcxx-commits] [PATCH] D99290: [libc++] Update contributor documentation.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

Typos and co.



================
Comment at: libcxx/docs/Contributing.rst:46
+name              The name of the feature-test macro.
+values            A list of tuples. One tuple contains a C++ version and the
+                  value of the feature-test marco for that C++ version.
----------------
Isn't it a dictionary (or however it's called in pythonesque)?


================
Comment at: libcxx/docs/Contributing.rst:88
 To regenerate the lists, use the target ``generate-cxx-abilist``.
+The ABI lists must be updated all supported platforms; currently Linux and Apple.
+If you don't have access to one of these platforms an updated list can be
----------------
Updated on/for?


================
Comment at: libcxx/docs/Contributing.rst:89
+The ABI lists must be updated all supported platforms; currently Linux and Apple.
+If you don't have access to one of these platforms an updated list can be
+downloaded from the failed build at
----------------



================
Comment at: libcxx/docs/Contributing.rst:92
+`Buildkite <https://buildkite.com/llvm-project/libcxx-ci>`__.
+Look for the failed build and select the ``artifacts`` tab. There download the
+abilist for the plafform, e.g.:
----------------



================
Comment at: libcxx/docs/Contributing.rst:93
+Look for the failed build and select the ``artifacts`` tab. There download the
+abilist for the plafform, e.g.:
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99290/new/

https://reviews.llvm.org/D99290