[libcxx-commits] [PATCH] D99290: [libc++] Update contributor documentation.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks a lot! Some comments but basically LGTM.



================
Comment at: libcxx/docs/Contributing.rst:61
+                  It shall not depend on a macro defined in ``include/__config``.
+internal_depends  An optional string field. When this field is provided
+                  ``depends`` must also be provided. It contains the dependency:
----------------
I think we should also change those names. I'd suggest:

```
depends => test_suite_guards
internal_depends => libcxx_guards
```

or something along those lines. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99290/new/

https://reviews.llvm.org/D99290