[libcxx-commits] [PATCH] D99263: [libcxx] [test] Link against msvcprt in tests

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D99263#2648618 <https://reviews.llvm.org/D99263#2648618>, @Mordante wrote:

> In the description the first sentence "This matches what". `what` -> `when`?

No, the sentence is the way I intended it to - "this matches what we do elsewhere"



================
Comment at: libcxx/utils/libcxx/test/config.py:480
                 debug_suffix = 'd' if self.debug_build else ''
                 self.cxx.link_flags += ['-lmsvcrt%s' % debug_suffix]
         else:
----------------
Mordante wrote:
> Is `msvcprt` required here?
Not sure - I'm not entirely sure of the full actual setup where this would be exercised. It might not be relevant here actually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99263/new/

https://reviews.llvm.org/D99263