[libcxx-commits] [PATCH] D99263: [libcxx] [test] Link against msvcprt in tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In the description the first sentence "This matches what". `what` -> `when`?

I'm not a Windows expert, so won't approve. However I don't see a real issue with the change.



================
Comment at: libcxx/utils/libcxx/test/config.py:480
                 debug_suffix = 'd' if self.debug_build else ''
                 self.cxx.link_flags += ['-lmsvcrt%s' % debug_suffix]
         else:
----------------
Is `msvcprt` required here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99263/new/

https://reviews.llvm.org/D99263