[libcxx-commits] [PATCH] D99104: [libcxx] renames and moves all concept tests

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 23 13:19:17 PDT 2021

zoecarver added a comment.

I won't oppose this patch, but FWIW, I would rather keep the `.compile.pass.cpp` tests and apply a comment as @CaseyCarter suggested. If there's a comment at the end of the function, I don't think anyone will accidentally modify it (and if they do, it will be easy to catch in review). Then we don't have to slow down the test suite (actually, it would be super interesting to see how much slower the test suite is after this change).

Comment at: libcxx/test/std/concepts/concepts.callable/concept.regularinvocable/regular_invocable.pass.cpp:20
-#include "functions.h"
+#include "../functions.h"
What do you think about doing this in two patches?
  1. rename `.compile.pass.cpp` -> `.pass.cpp`.
  2. move around the location in tree/rename files.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list