[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Finish constexpr-ifying <iterator>, <string_view>, <tuple>, <utility>.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone marked 4 inline comments as done.
Quuxplusone added inline comments.


================
Comment at: libcxx/include/version:340
 # define __cpp_lib_list_remove_return_type              201806L
-# ifndef _LIBCPP_HAS_NO_CONCEPTS
+# if defined(__cpp_concepts) && __cpp_concepts >= 201907L
 #   define __cpp_lib_math_constants                     201907L
----------------
ldionne wrote:
> Why is this changing?
Fallout from D97904. I'll re-upload.


================
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.creation/make_tuple.pass.cpp:14
 // template<class... Types>
 //   tuple<VTypes...> make_tuple(Types&&... t);
 
----------------
ldionne wrote:
> Isn't that `constexpr` since C++14?
`make_tuple` is; but the test case I'm modifying here also uses `std::ref`, which is constexpr in C++20 only.


================
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.creation/tie.pass.cpp:16
 
 // UNSUPPORTED: c++03
 
----------------
ldionne wrote:
> Same, this is constexpr since C++14?
Yes, but `res = std::make_tuple(101, nullptr, -1.0);` on line 38 is constexpr only in C++20 because `operator=`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96385/new/

https://reviews.llvm.org/D96385