[libcxx-commits] [PATCH] D96385: [libc++] [P1032] Finish constexpr-ifying <iterator>, <string_view>, <tuple>, <utility>.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 23 11:03:59 PDT 2021
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
This looks pretty good, but it seems that you included some changes that were not strictly added in P1032 <https://reviews.llvm.org/P1032> in this patch too (eg some tests for tuple being constexpr). I'm fine with that, but I'd like to confirm that this was intentional.
Comment at: libcxx/include/version:340
# define __cpp_lib_list_remove_return_type 201806L
-# ifndef _LIBCPP_HAS_NO_CONCEPTS
+# if defined(__cpp_concepts) && __cpp_concepts >= 201907L
# define __cpp_lib_math_constants 201907L
Why is this changing?
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.creation/make_tuple.pass.cpp:14
// template<class... Types>
// tuple<VTypes...> make_tuple(Types&&... t);
Isn't that `constexpr` since C++14?
Comment at: libcxx/test/std/utilities/tuple/tuple.tuple/tuple.creation/tie.pass.cpp:16
// UNSUPPORTED: c++03
Same, this is constexpr since C++14?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits