[libcxx-commits] [PATCH] D99095: [libcxx] [test] Add XFAIL LIBCXX-WINDOWS-FIXME in 124 tests that fail in the CI configuration

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 22 11:54:06 PDT 2021

mstorsjo added a comment.

In D99095#2642171 <https://reviews.llvm.org/D99095#2642171>, @Quuxplusone wrote:

> Sounds plausible to me, as long as you remember after this lands that all those other PRs will need to be updated to remove the `XFAIL` line from the files they affect. (git itself won't detect an explicit merge conflict.)
> Should be easy to remember, though, because all the lines-to-be-removed contain the string `LIBCXX-WINDOWS-FIXME`; right?

Yeah, I'll keep that in sync with the other patches. For some patches, it's a bit tricky as there might be two patches in review that fixes different issues in the same file, so then the one that lands later needs to do that. But yeah, I'll keep track of it.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list