[libcxx-commits] [PATCH] D99095: [libcxx] [test] Add XFAIL LIBCXX-WINDOWS-FIXME in 124 tests that fail in the CI configuration

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 22 11:46:10 PDT 2021


Quuxplusone added a comment.

Sounds plausible to me, as long as you remember after this lands that all those other PRs will need to be updated to remove the `XFAIL` line from the files they affect. (git itself won't detect an explicit merge conflict.)
Should be easy to remember, though, because all the lines-to-be-removed contain the string `LIBCXX-WINDOWS-FIXME`; right?
I'll withhold an "accept" to see if anyone else has thoughts on the approach; but I'm happy to be a +1 on this if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99095/new/

https://reviews.llvm.org/D99095



More information about the libcxx-commits mailing list