[libcxx-commits] [PATCH] D97870: [libc++] Add missing header <cuchar>

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/test/std/strings/c.strings/cuchar.pass.cpp:22
+int main(int, char**) {
+#if TEST_STD_VER > 17 && !defined(_LIBCPP_VERSION) // TODO: implement this in libc++
+    ASSERT_SAME_TYPE(size_t, decltype(std::mbrtoc8((char8_t*)0, (char const*)0, size_t(), (mbstate_t*)0)));
----------------
Shouldn't this be guarded on support of `char8_t` as well?

```
#if TEST_STD_VER > 17 && defined(__cpp_char8_t) ...
// or
#if defined(__cpp_lib_char8_t) && __cpp_lib_char8_t >= 201811L ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97870/new/

https://reviews.llvm.org/D97870