[libcxx-commits] [PATCH] D97870: [libc++] Add missing header <cuchar>
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 5 14:03:39 PST 2021
curdeius added a comment.
I see from the build failures that char16_t typedefs should be guarded not to conflict with C++ built-in types. At least for glibc the solution will be to define `__USE_ISOCXX11`, cf. https://sourceware.org/git/?p=glibc.git;a=blob;f=wcsmbs/uchar.h;h=6020f66cf6d27d86d78213c3efdf17a9e52f45e7;hb=HEAD.
Other thing, with this patch you add cuchar header, but there is no intermediate uchar.h in libc++ as it's done for other headers (which then #include_next their C library equivalent). I guess that it should be added here and it will probably be the place to define the aforementioned macro guard.
Correct me if I'm wrong.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits