[libcxx-commits] [PATCH] D98771: [libcxx][Arm] Move buildbot flags into cmake files
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 18 10:22:39 PDT 2021
ldionne added a comment.
I think it makes sense for those ARM builders to be executed only when the other jobs succeed since they don't have basically unlimited bandwidth. I think it almost only makes sense to put the jobs running on GCE in the first section.
In D98771#2634844 <https://reviews.llvm.org/D98771#2634844>, @curdeius wrote:
> Sorry for changing my mind.
> What about:
> -DLIBCXX_ENABLE_EXCEPTIONS=OFF \
> They should be in cmake caches too, no?
I am ambivalent about that one. On the one hand, I agree this should be in a cache, however that could lead to a large number of caches if we always put each configuration in a cache of its own. I'd say let's go for a separate cache right now just so there's a 1-1 correspondence between CMake caches and supported configurations, but let's revisit this in the future if it doesn't make sense anymore.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits