[libcxx-commits] [PATCH] D98640: [libcxx] [test] Fix windows errors in fs.op.rename

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D98640#2628968 <https://reviews.llvm.org/D98640#2628968>, @Quuxplusone wrote:

> LGTM! Although, if you wanted to scope-creep it, it might be nice to add a positive test for Windows' actual behavior. Right now IIUC you're making Windows lose all test coverage for this (interesting) case.

I can look into doing that later as follow-up. I see that the test otherwise also is lacking positive tests for renaming directories, and negative tests for dir->dir renames.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98640/new/

https://reviews.llvm.org/D98640