[libcxx-commits] [PATCH] D98640: [libcxx] [test] Fix windows errors in fs.op.rename

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 16 07:08:10 PDT 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM! Although, if you wanted to scope-creep it, it might be nice to add a positive test for Windows' actual behavior. Right now IIUC you're making Windows lose all test coverage for this (interesting) case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98640/new/

https://reviews.llvm.org/D98640



More information about the libcxx-commits mailing list