[libcxx-commits] [PATCH] D98443: [libcxx] [test] Use GetWindowsInaccessibleDir() in a couple more tests

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.mods/assign.pass.cpp:108
+  const path sym_out_of_dir = env.create_symlink(file, "sym");
+  {
+    directory_entry ent;
----------------
mstorsjo wrote:
> curdeius wrote:
> > I'd like a small comment here about the difference on Windows, as we cannot create any file inside the inaccessible directory so we cannot test the same thing.
> Ok, amended it locally with this comment:
> ```
>   // We can't create files in the directory we use as inaccessible directory
>   // for tests on Windows, so this doesn't test exactly the same as the
>   // code below.
> ```
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98443/new/

https://reviews.llvm.org/D98443