[libcxx-commits] [PATCH] D98443: [libcxx] [test] Use GetWindowsInaccessibleDir() in a couple more tests
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 11 23:55:44 PST 2021
mstorsjo added inline comments.
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.mods/assign.pass.cpp:108
+ const path sym_out_of_dir = env.create_symlink(file, "sym");
+ directory_entry ent;
> I'd like a small comment here about the difference on Windows, as we cannot create any file inside the inaccessible directory so we cannot test the same thing.
Ok, amended it locally with this comment:
// We can't create files in the directory we use as inaccessible directory
// for tests on Windows, so this doesn't test exactly the same as the
// code below.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits