[libcxx-commits] [PATCH] D98141: [libcxx] [test] Disable a test regarding error behaviour for excessively long paths on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 11 10:14:30 PST 2021

mstorsjo added a comment.

In D98141#2620073 <https://reviews.llvm.org/D98141#2620073>, @Mordante wrote:

> I see a build failure, I expect it to be a flacky failure. Can you either rerun the CI or keep an eye out after landing.
> LGTM with a minor nit.

As it's just adding an ifdef, I'd guess it's just a spurious unrelated error, but I'll keep an eye out.

Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp:89
+#ifndef _WIN32
+// Checking for the existance of an invalidly long path name doesn't
+// trigger errors on windows.
Mordante wrote:
> curdeius wrote:
> > mstorsjo wrote:
> > > Quuxplusone wrote:
> > > > /existance/existence/
> > > > 
> > > > Do you have any idea why line 85 does `TEST_CHECK_THROW`, but none of the other test cases in this file do?
> > > Will fix the typo.
> > > 
> > > No idea, either just random inconsistency, or whoever wrote it thought it was enough to test both error reporting paths in one place, and assume it's enough to test either of them in other cases.
> > I think we miss in lots of places the tests of throwing versions.
> s/invalidly/invalid/
Thanks, will fix.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list