[libcxx-commits] [PATCH] D98141: [libcxx] [test] Disable a test regarding error behaviour for excessively long paths on windows

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

I see a build failure, I expect it to be a flacky failure. Can you either rerun the CI or keep an eye out after landing.
LGTM with a minor nit.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp:89
+#ifndef _WIN32
+// Checking for the existance of an invalidly long path name doesn't
+// trigger errors on windows.
----------------
curdeius wrote:
> mstorsjo wrote:
> > Quuxplusone wrote:
> > > /existance/existence/
> > > 
> > > Do you have any idea why line 85 does `TEST_CHECK_THROW`, but none of the other test cases in this file do?
> > Will fix the typo.
> > 
> > No idea, either just random inconsistency, or whoever wrote it thought it was enough to test both error reporting paths in one place, and assume it's enough to test either of them in other cases.
> I think we miss in lots of places the tests of throwing versions.
s/invalidly/invalid/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98141/new/

https://reviews.llvm.org/D98141