[libcxx-commits] [PATCH] D97308: Add noreturn attribute to non-returning functions

[Aditya Kumar via Phabricator via libcxx-commits]

hiraditya added a comment.

In D97308#2611794 <https://reviews.llvm.org/D97308#2611794>, @Quuxplusone wrote:

> I did a grep for `void __throw` and verified that every other instance is attributed, except for:
>
> - `__throw_if_valueless` in <variant>: this is good and intentional
> - `void __throw_runtime_error(const char* msg)` in `src/locale.cpp`: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with `noreturn` https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97308/new/

https://reviews.llvm.org/D97308