[libcxx-commits] [PATCH] D97308: Add noreturn attribute to non-returning functions
Aditya Kumar via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 10 00:03:39 PST 2021
hiraditya added a comment.
In D97308#2611794 <https://reviews.llvm.org/D97308#2611794>, @Quuxplusone wrote:
> I did a grep for `void __throw` and verified that every other instance is attributed, except for:
> - `__throw_if_valueless` in <variant>: this is good and intentional
> - `void __throw_runtime_error(const char* msg)` in `src/locale.cpp`: what's the deal with this one? should you attribute it as well?
__throw_runtime_error is attributed with `noreturn` https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits