[libcxx-commits] [PATCH] D97308: Add noreturn attribute to non-returning functions

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 8 10:50:47 PST 2021


Quuxplusone added a comment.

I did a grep for `void __throw` and verified that every other instance is attributed, except for:

- `__throw_if_valueless` in <variant>: this is good and intentional
- `void __throw_runtime_error(const char* msg)` in `src/locale.cpp`: what's the deal with this one? should you attribute it as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97308/new/

https://reviews.llvm.org/D97308



More information about the libcxx-commits mailing list