[libcxx-commits] [PATCH] D98166: [libcxx] Test accessing a directory on windows that gives "access denied" errors

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 9 01:41:42 PST 2021

mstorsjo added a comment.

In D98166#2613267 <https://reviews.llvm.org/D98166#2613267>, @mstorsjo wrote:

> Ok, speaking up myself here: If running tests within wine instead of on an actual windows installation, this path doesn't exist.
> Running tests in wine might not be a situation that we want to explicitly support, but it does overall work fairly well. (The filesystem tests almost all work flawlessly there except for some symlink related corner cases.)

Then again, it's not much of an issue to carry a local patch that allows this failure, for branches where I test with wine (I have a commit that adds a other executor, like run.py and ssh.py, for wrapping the tools with wine, that probably isn't to be upstreamed anyway).

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list