[libcxx-commits] [PATCH] D98166: [libcxx] Test accessing a directory on windows that gives "access denied" errors

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D98166#2610897 <https://reviews.llvm.org/D98166#2610897>, @mstorsjo wrote:

>> I think that we should check it as a precondition of a test. Just returning if the dir is not found may lead to some stupid errors and dead tests.
>> Is there any case where this path would be inaccessible? MinGW? I mean apart from having a very old OS or no C: partition?
>
> I guess there could be odd installation setups where it isn't available, but as you say, it seems to be available on most setups, so it might be best to just require that it is, and clearly safer against silently missing testcases. And if someone actually runs these tests on windows and fails due to this, they can of course speak up.

Ok, speaking up myself here: If running tests within wine instead of on an actual windows installation, this path doesn't exist.

Running tests in wine might not be a situation that we want to explicitly support, but it does overall work fairly well. (The filesystem tests almost all work flawlessly there except for some symlink related corner cases.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98166/new/

https://reviews.llvm.org/D98166