[libcxx-commits] [PATCH] D98109: [libcxx] Make path::absolute return paths with separators in preferred form

Mon Mar 8 12:05:16 PST 2021

mstorsjo added a comment.

In D98109#2611911 <https://reviews.llvm.org/D98109#2611911>, @curdeius wrote:

> I would rather go for your third alternative (so using operator== instead of PathEq) to test what is asked by standard and, optionally, test libc++ specifics using LIBCPP_ONLY macro or its pairs (e.g. using PathEq on non-Windows).
> I know it loosens the test a bit, but as you say some tests are overly specific.

Ok, I can go with that.

> Anyway, all that according to my understanding of http://eel.is/c++draft/fs.op.absolute and other related parts of the standard. I'll be happy to hear your and others' interpretation (if it differs).

Well that one does say that it may have the same semantics as `GetFullPathNameW` on windows, and `GetFullPathNameW` does return a path with all backslashes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98109/new/

https://reviews.llvm.org/D98109