[libcxx-commits] [PATCH] D98109: [libcxx] Make path::absolute return paths with separators in preferred form
Marek Kurdej via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 8 11:28:15 PST 2021
curdeius added a comment.
I would rather go for your third alternative (so using operator== instead of PathEq) to test what is asked by standard and, optionally, test libc++ specifics using LIBCPP_ONLY macro or its pairs (e.g. using PathEq on non-Windows).
I know it loosens the test a bit, but as you say some tests are overly specific.
Anyway, all that according to my understanding of http://eel.is/c++draft/fs.op.absolute and other related parts of the standard. I'll be happy to hear your and others' interpretation (if it differs).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits