[libcxx-commits] [PATCH] D98138: [libcxx] [test] Don't test CharFile (/dev/null) on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 7 13:32:10 PST 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG3a11a41795be: [libcxx] [test] Don't test CharFile (/dev/null) on windows (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D98138?vs=328872&id=328902#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98138/new/

https://reviews.llvm.org/D98138

Files:
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.symlink_status/symlink_status.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.symlink_status/symlink_status.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.symlink_status/symlink_status.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.symlink_status/symlink_status.pass.cpp
@@ -118,8 +118,10 @@
         {static_env.SymlinkToFile, file_type::symlink},
         {static_env.Dir, file_type::directory},
         {static_env.SymlinkToDir, file_type::symlink},
-        // Block files tested elsewhere
+        // file_type::block files tested elsewhere
+#ifndef _WIN32
         {static_env.CharFile, file_type::character},
+#endif
 #if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(_WIN32) // No support for domain sockets
         {env.create_socket("socket"), file_type::socket},
 #endif
Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.status/status.pass.cpp
@@ -109,8 +109,10 @@
         {static_env.SymlinkToFile, file_type::regular},
         {static_env.Dir, file_type::directory},
         {static_env.SymlinkToDir, file_type::directory},
-        // Block files tested elsewhere
+        // file_type::block files tested elsewhere
+#ifndef _WIN32
         {static_env.CharFile, file_type::character},
+#endif
 #if !defined(__APPLE__) && !defined(__FreeBSD__) && !defined(_WIN32) // No support for domain sockets
         {env.create_socket("socket"), file_type::socket},
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98138.328902.patch
Type: text/x-patch
Size: 1756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210307/56770ab4/attachment.bin>


More information about the libcxx-commits mailing list