[libcxx-commits] [PATCH] D98138: [libcxx] [test] Don't test CharFile (/dev/null) on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 7 13:25:07 PST 2021


mstorsjo added a comment.

In D98138#2610071 <https://reviews.llvm.org/D98138#2610071>, @curdeius wrote:

> LGTM. Could you put a similar comment (but concerning only Windows of course) near `file_type::character` declaration as well?

In the header? Sure, I can make a separate patch for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98138/new/

https://reviews.llvm.org/D98138



More information about the libcxx-commits mailing list