[libcxx-commits] [PATCH] D98140: [libcxx] [test] Fix building create_directory in MSVC configurations

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 7 13:32:05 PST 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG52c5f5ad5f20: [libcxx] [test] Fix building create_directory in MSVC configurations (authored by mstorsjo).

Changed prior to commit:
  https://reviews.llvm.org/D98140?vs=328854&id=328901#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98140/new/

https://reviews.llvm.org/D98140

Files:
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.create_directory/create_directory.pass.cpp
@@ -32,7 +32,7 @@
 using namespace fs;
 
 fs::perms read_umask() {
-    mode_t old_mask = umask(0);
+    auto old_mask = umask(0); // int on Windows, mode_t on POSIX.
     umask(old_mask); // reset the mask to the old value.
     return static_cast<fs::perms>(old_mask);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98140.328901.patch
Type: text/x-patch
Size: 663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210307/49420b56/attachment-0001.bin>


More information about the libcxx-commits mailing list