[libcxx-commits] [PATCH] D98141: [libcxx] [test] Disable a test regarding error behaviour for excessively long paths on windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Mar 7 02:21:27 PST 2021

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Checking for the existence of an invalidly long path name isn't
an error in itself on windows.

  rG LLVM Github Monorepo



Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp
@@ -89,6 +89,9 @@
+#ifndef _WIN32
+// Checking for the existance of an invalidly long path name doesn't
+// trigger errors on windows.
 TEST_CASE(test_name_too_long) {
     std::string long_name(2500, 'a');
     const path file(long_name);
@@ -97,5 +100,6 @@
     TEST_CHECK(exists(file, ec) == false);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98141.328855.patch
Type: text/x-patch
Size: 697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210307/a7b67911/attachment.bin>

More information about the libcxx-commits mailing list