[libcxx-commits] [PATCH] D98141: [libcxx] [test] Disable a test regarding error behaviour for excessively long paths on windows
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Mar 7 12:52:44 PST 2021
mstorsjo added a comment.
In D98141#2610084 <https://reviews.llvm.org/D98141#2610084>, @curdeius wrote:
> I don't understand why this test fails on Windows. The length of the path should have nothing to do here, the file doesn't exist even if we suppose that the filename gets truncated to 256 characters.
> It sounds like some subjacent issue, no?
No, it's not about whether the file exists or not - when we have `bool exists(path, error_code&)`, a normal nonexistent file doesn't flag any error, and returns false - but this test expects the error code to be set. So its line 94 originally or 97 in the patched version, that fails on windows. (And I don't think there's much need in keeping the rest of this test and just ifdef out that single line, as we have other tests for nonexistent files above.)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits