[libcxx-commits] [PATCH] D98141: [libcxx] [test] Disable a test regarding error behaviour for excessively long paths on windows

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

I don't understand why this test fails on Windows. The length of the path should have nothing to do here, the file doesn't exist even if we suppose that the filename gets truncated to 256 characters.
It sounds like some subjacent issue, no?



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp:89
+#ifndef _WIN32
+// Checking for the existance of an invalidly long path name doesn't
+// trigger errors on windows.
----------------
mstorsjo wrote:
> Quuxplusone wrote:
> > /existance/existence/
> > 
> > Do you have any idea why line 85 does `TEST_CHECK_THROW`, but none of the other test cases in this file do?
> Will fix the typo.
> 
> No idea, either just random inconsistency, or whoever wrote it thought it was enough to test both error reporting paths in one place, and assume it's enough to test either of them in other cases.
I think we miss in lots of places the tests of throwing versions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98141/new/

https://reviews.llvm.org/D98141