[libcxx-commits] [PATCH] D98065: [libcxx] Remove an unused overload in filesystem_common.h. NFC.
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 5 13:05:33 PST 2021
mstorsjo added a comment.
In D98065#2607603 <https://reviews.llvm.org/D98065#2607603>, @Quuxplusone wrote:
> Sure, assuming it passes tests.
> However, eyeballing the uses of this thing, I got to directory_iterator.cpp, which does
> err.report(m_ec, "at root \"%s\"", root);
> That produces garbage on Windows, right? because `root` is a `path` and the way we `unwrap(path const&)` is to turn it into a `wchar_t*`, not a `char*`?
Oh, you're right - I had missed that one (I have the same issue fixed in a couple other cases in operations.cpp). Thanks! I tried applying D96986 <https://reviews.llvm.org/D96986> and then I do get format warnings that point out exactly this.
I'll get a fix posted for that issue.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits