[libcxx-commits] [PATCH] D98065: [libcxx] Remove an unused overload in filesystem_common.h. NFC.
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 5 12:42:39 PST 2021
Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.
Sure, assuming it passes tests.
However, eyeballing the uses of this thing, I got to directory_iterator.cpp, which does
err.report(m_ec, "at root \"%s\"", root);
That produces garbage on Windows, right? because `root` is a `path` and the way we `unwrap(path const&)` is to turn it into a `wchar_t*`, not a `char*`?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits