[libcxx-commits] [PATCH] D98065: [libcxx] Remove an unused overload in filesystem_common.h. NFC.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

Sure, assuming it passes tests.
However, eyeballing the uses of this thing, I got to directory_iterator.cpp, which does

  err.report(m_ec, "at root \"%s\"", root);

That produces garbage on Windows, right? because `root` is a `path` and the way we `unwrap(path const&)` is to turn it into a `wchar_t*`, not a `char*`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98065/new/

https://reviews.llvm.org/D98065