[libcxx-commits] [PATCH] D46443: Add missing cstdalign header
Sam Clegg via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 5 08:12:38 PST 2021
sbc100 added inline comments.
================
Comment at: libcxx/test/libcxx/utilities/any/size_and_alignment.pass.cpp:16
#include <any>
+#include <cstdalign>
----------------
curdeius wrote:
> This doesn't seem to be necessary. Or?
> In C++, `alignof` is a keyword.
You are right its not necessary in C++ since its a keyword. My memory of exactly why I added to this file in the original version of the CL back in 2018 is ... missing. Maybe its to ensure that the inclusion of the C header and the macro don't interfere with C++ usage?
I'm happy to revert this line and find a better way to test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D46443/new/
https://reviews.llvm.org/D46443
More information about the libcxx-commits
mailing list