[libcxx-commits] [PATCH] D46443: Add missing cstdalign header

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/include/cstdalign:19-22
+   alignof
+   alignas
+    __alignof_is_defined
+    __alignas_is_defined
----------------
You should test that each of these macros is really defined when including `cstdalign`.


================
Comment at: libcxx/test/libcxx/utilities/any/size_and_alignment.pass.cpp:16
 #include <any>
+#include <cstdalign>
 
----------------
This doesn't seem to be necessary. Or?
In C++, `alignof` is a keyword.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46443/new/

https://reviews.llvm.org/D46443