[libcxx-commits] [PATCH] D98035: [libcxx] Don't add -Wall when building in MSVC mode

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/CMakeLists.txt:582
                                                           -Wno-unused-parameter -Wno-long-long
                                                           -Werror=return-type -Wextra-semi)
   if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
----------------
Quuxplusone wrote:
> LGTM too. I'm in the habit of treating `-W4` as the MSVC equivalent of `-Wall`; you might consider trying out `-W4` here if you haven't already, just for curiosity's sake.
It would be nice indeed to use `-W4` if possible, and otherwise `-W3` (or lower level).
If `-W4`/`-W3` is not ok, maybe you might add a FIXME comment and we will work on it later (when a Windows CI builder is available)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98035/new/

https://reviews.llvm.org/D98035