[libcxx-commits] [PATCH] D98035: [libcxx] Don't add -Wall when building in MSVC mode

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added inline comments.


================
Comment at: libcxx/CMakeLists.txt:582
                                                           -Wno-unused-parameter -Wno-long-long
                                                           -Werror=return-type -Wextra-semi)
   if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
----------------
LGTM too. I'm in the habit of treating `-W4` as the MSVC equivalent of `-Wall`; you might consider trying out `-W4` here if you haven't already, just for curiosity's sake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98035/new/

https://reviews.llvm.org/D98035