[libcxx-commits] [PATCH] D98021: [libcxxabi] Add LIBCXXABI_HAS_WIN32_THREAD_API build option

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 5 06:26:43 PST 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I'm really unhappy about this, but we do have `LIBCXX_HAS_WIN32_THREAD_API` so let's add this for consistency. When we find a way to replace these explicit settings for picking the threading API, we can remove them in both libc++ and libc++abi.

NB: The reason why I don't like this is that we normally never bake in this sort of detection in the CMake. I think it's a layering violation to do so. But like I said above, this is a pre-existing condition and this patch at least makes the layering violation consistent between libcxx and libcxxabi.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list