[libcxx-commits] [PATCH] D98021: [libcxxabi] Add LIBCXXABI_HAS_WIN32_THREAD_API build option
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 5 02:05:07 PST 2021
mstorsjo accepted this revision.
mstorsjo added a comment.
This LGTM (but I'm not a libcxx/libcxxabi approver, so you'll need to wait for the green checkmark for the libc++abi reviewer group), given the existing predecent with similar options for all other threading configurations. I've ran into this myself in various constellations, and in those cases worked around it by just passing `-D_LIBCPP_HAS_THREAD_API_WIN32` in `CMAKE_CXX_FLAGS`, which is clearly a hack.
FWIW, there's work ongoing (see D97572 <https://reviews.llvm.org/D97572>) to make `__config_site` available directly which should avoid the issue if I remember correctly - and that would make these options in libcxxabi that mirror libcxx options redundant. But until that's in place, and since we already have these other ones, I think this looks sensible.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits