[libcxx-commits] [PATCH] D97904: [libcxx] updates the feature-test macro generator

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

>> Maybe one of the other newly minted libc++ approvers can give it the libc++ stamp of approval. :)
>
> Yes please! I didn't see @ldionne's email till after I put this up.

I can :-) LGTM.



================
Comment at: libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp:4099
 #   ifdef __cpp_lib_math_constants
-#     error "__cpp_lib_math_constants should not be defined when defined(__cpp_concepts) && __cpp_concepts >= 201907L is not defined!"
+#     error "__cpp_lib_math_constants should not be defined when !defined(_LIBCPP_HAS_NO_CONCEPTS) is not defined!"
 #   endif
----------------
cjdb wrote:
> This (and elsewhere) feels wrong to me.
It looks odd, but it's correct. It has been added in D82171 since the it broke some build bots. The header contains the `__floating_point` concept. (the `std::` added in that patch is no longer there.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97904/new/

https://reviews.llvm.org/D97904