[libcxx-commits] [PATCH] D97904: [libcxx] updates the feature-test macro generator

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp:4099
 #   ifdef __cpp_lib_math_constants
-#     error "__cpp_lib_math_constants should not be defined when defined(__cpp_concepts) && __cpp_concepts >= 201907L is not defined!"
+#     error "__cpp_lib_math_constants should not be defined when !defined(_LIBCPP_HAS_NO_CONCEPTS) is not defined!"
 #   endif
----------------
This (and elsewhere) feels wrong to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97904/new/

https://reviews.llvm.org/D97904