[libcxx-commits] [PATCH] D97015: [libcxx] cleans up __cpp_concepts mess
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 3 18:12:09 PST 2021
cjdb added a comment.
In D97015#2599338 <https://reviews.llvm.org/D97015#2599338>, @Quuxplusone wrote:
> @cjdb, after this landed and then @zoecarver's D60368 <https://reviews.llvm.org/D60368> landed on top of it and maybe merge-conflicted with it... I'm now seeing that the feature-test-macro tests that are checked in **do not match** the output you get by running the `libcxx/utils/generate_feature_test_macro_components.py ` script. Could you (@cjdb) run `libcxx/utils/generate_feature_test_macro_components.py` locally, check whether it matches what you intended, and if so, check in those changes? (If the generated output //doesn't// match what you intended, then probably you should post another PR.)
Nice catch! Looking at the diff here, it appears that I didnt' change libcxx/utils/generate_feature_test_macro_components.py properly. Making a patch for it now.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits