[libcxx-commits] [PATCH] D96786: Including <ciso646> should result in an #error since C++17

Tue Mar 2 00:24:22 PST 2021

georgthegreat added a comment.

Ok, I have run CI check on a large codebase too.

`<ciso646>` is a real problem here, but I see no real world inclusions of either <ctgmath>, <cstdbool> or <ccomplex>.

How about fixing these three, leaving <ciso646> unchanged? As far, as I see, there is no legal replacement for <ciso646> in C++17, as <version> only appears in C++20.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96786/new/

https://reviews.llvm.org/D96786