[libcxx-commits] [PATCH] D96786: Including <ciso646> should result in an #error since C++17
Marshall Clow via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 1 15:17:44 PST 2021
mclow.lists added a comment.
>> (2.3) — a #include of <ciso646>, <cstdalign>, or <cstdbool> can simply be removed.
> This makes me think that it maybe better to generate `#error` instead of trying to workaround MSVC problem.
> @mclow.lists, @ldionne, what do you think?
I disagree. We have given people guidance that `#include <ciso646>` is a useful way to identify which standard library you are using.
See https://stackoverflow.com/questions/31657499/how-to-detect-stdlib-libc-in-the-preprocessor as an example.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits