[libcxx-commits] [PATCH] D104682: [libc++] Enable `explicit` conversion operators, even in C++03 mode.

Tue Jun 22 10:09:55 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I just read https://reviews.llvm.org/D104172#2830696.

I think we need to figure out what to do with C++03 in the test suite (you accurately explained the state of things in https://reviews.llvm.org/D104172#2830696, but that state of things is not what it should be IMO). However, this patch is orthogonal to figuring that out, so I'm fine with it. Thanks a lot for the clean up!

================
Comment at: libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.obs/op_bool.pass.cpp:13
-// dylib support for shared_mutex was added in macosx10.12
-// XFAIL: use_system_cxx_lib && x86_64-apple-macosx10.11
-// XFAIL: use_system_cxx_lib && x86_64-apple-macosx10.10
----------------
Thanks for that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104682/new/

https://reviews.llvm.org/D104682