[libcxx-commits] [PATCH] D104682: [libc++] Enable `explicit` conversion operators, even in C++03 mode.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

So the logic here is that we're not adding `// UNSUPPORTED: c++03` to those tests even though they technically require C++11 (since we're testing stuff like `std::shared_ptr`, which was added in C++11), because libc++ implements those types as an extension?

I think it would be more logical to use `// UNSUPPORTED: c++03 && !libc++`. That way, other standard libraries that do not support those types in C++03 mode will not fail the test suite. WDYT?

Other than that, I'm fine with the changes and I like that we're removing workarounds for missing C++03 language features.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104682/new/

https://reviews.llvm.org/D104682