[libcxx-commits] [PATCH] D89353: Enable overriding `__libcpp_debug_function` invocation

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 15 14:32:43 PDT 2021


rnk added a comment.

In D89353#2811149 <https://reviews.llvm.org/D89353#2811149>, @ldionne wrote:

> If I understand correctly, the main problem being solved by this patch is that Chromium does not want to have those `__FILE__` string constants stored in the compiled binaries (because it doesn't use that information anyway)?

As I understand it, the plan is to actually ship with these checks enabled. This expands the scope of these debug mode checks from a testing tool to a security hardening tool. That's why the binary size matters: it will ship to users. It starts from the simple idea that `std::vector<>::operator[]` could have bounds checks, and one way to get there is to enable debug checks and add this override mechanism.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89353/new/

https://reviews.llvm.org/D89353



More information about the libcxx-commits mailing list