[libcxx-commits] [PATCH] D89353: Enable overriding `__libcpp_debug_function` invocation

[Chris Palmer via Phabricator via libcxx-commits]

palmer added a comment.

> If I understand correctly, the main problem being solved by this patch is that Chromium does not want to have those `__FILE__` string constants stored in the compiled binaries (because it doesn't use that information anyway)?

It's not just the string constants, it's that we want everything about the code to be as small as possible:

"But, we are very sensitive to object code size, and the standard implementation has those print statements (which can get big). This macro allows us to use the smallest possible crash code (e.g. a ud2 on Intel, or the like), and thus have the least impact on our overall object code size."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89353/new/

https://reviews.llvm.org/D89353